-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "extension_order" option #181
base: master
Are you sure you want to change the base?
Conversation
Added "extension_order" option to the "buidout" section. This allows you to specify the order in which the declared extensions are loaded.
I don't see any documentation for this, or tests either. |
It took me a while to understand why the existing (It enumerates Python packages, that is, distributions, and each of those might conceivably contain several buildout extensions by providing multiple (named) entry points.) |
I'd gladly write tests and documentation. Did a quick search for documentation of the "extensions" option but did not find much. So I assumed it's some undocumented feature and didn't want to write documentation for extensions related stuff when extensions are not fully documented. But I could do that as well when you give me a place to write my stuff. As for the test, I tried one, but I am not too familiar with that doctests format. I tried to adopt an existing extensions test but I could not figure out how to actually test the order in which extensions are loaded. It seems, that only stuff which is observable from a users perspective is tested, did not find a unit test for extensions. Are there some better examples? |
While zc.buildout's documentation is not stellar, extensions are documented: The source for that documentation is buildout/src/zc/buildout/buildout.txt Line 3031 in 08c34b8
As for tests, I agree that doctests are hard to modify. Creating a new doctest (extension-order.txt) might be simplest. Add a couple of extensions that print stuff to sys stdout, show a couple of buildout configs that put them in different order, see how they get printed. (I should probably mention that I'm not the primary maintainer of zc.buildout -- @jimfulton is. I'm not familiar with buildout's implementation details. I may comment on stylistic issues in patches, but it's Jim's decision whether features should be merged or not. Unfortunately he hasn't been very responsive lately -- probably very busy with other projects.) |
Ok, I see, did not find those files. Will see that the feature gets documented. Your idea for the test sounds very reasonable. I will do that asap. Well, I hope @jimfulton will find some time in the future. Thanks for the good support! |
Why do you need a separate extension order option? Cannot you get buildout to respect the order given in the actual It might be that I mis-understand, though. In any case, we need documentation or tests. Or is there some input or help that you need? |
b8ad13b
to
5db2e99
Compare
Added "extension_order" option to the "buidout" section.
This allows you to specify the order in which the declared
extensions are loaded.