Fix for issue 176: extends with increments can result in missing values #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested fix for issue 176. I've added a test case based on the one presented in that issue, but have expanded it to test various combinations of operations.
The basic approach is to parse all the extended files before applying them, so that nothing gets lost along the way. Additionally, all annotations are kept so that even if a = overrides previous settings, the operation is captured so the problem can more easily be found.
I believe the fix behaves consistently, so that =, -= and += behave as expected within the order of extends operations. As the test case shows, you can do some stupid things, but it does them consistently. ;-)