Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run easy_install with specified setuptools_version #232

Merged
merged 1 commit into from
Jun 10, 2015

Conversation

lrowe
Copy link
Contributor

@lrowe lrowe commented Jan 8, 2015

If setuptools is installed globally by easy_install then the easy_install.pth gets added to sys.path before PYTHONPATH and the wrong setuptools version is used.

Any chance of a 2.2.6 with this fix included?

If setuptools is installed globally by easy_install then the easy_install.pth gets added to sys.path before PYTHONPATH and the wrong setuptools version is used.
@tseaver
Copy link
Contributor

tseaver commented Jan 8, 2015

LGTM

@lrowe
Copy link
Contributor Author

lrowe commented Jan 9, 2015

If we do have a 2.2.6 including this then the equivalent fix for bootstrap.py in #223 should probably be included too.

@reinout
Copy link
Contributor

reinout commented Jun 10, 2015

Agree with the LGTM, merging it. I'll add a changelog entry on master.

reinout added a commit that referenced this pull request Jun 10, 2015
Run easy_install with specified setuptools_version
@reinout reinout merged commit 2c16519 into buildout:master Jun 10, 2015
@reinout
Copy link
Contributor

reinout commented Jun 10, 2015

Changelog added in b84e20d, @lrowe, is it OK like that?

reinout added a commit that referenced this pull request Jun 10, 2015
Run easy_install with specified setuptools_version, same change as #232
@reinout
Copy link
Contributor

reinout commented Jun 10, 2015

@lrowe, you probably meant that #222 should be included? Instead of the #223 you mention? (Just making sure)

@lrowe
Copy link
Contributor Author

lrowe commented Jun 10, 2015

@reinout - yup, I mistyped. #222 is the equivalent fix for bootstrap.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants