-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for kpack CONTRIBUTORS.md #1149
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
+ Coverage 70.01% 70.03% +0.01%
==========================================
Files 132 132
Lines 6677 6671 -6
==========================================
- Hits 4675 4672 -3
+ Misses 1573 1570 -3
Partials 429 429 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Out of curiosity, @jjbustamante when do you want to merge this PR? Just wondering what happens when someone emails |
I believe we wanted to keep this PR open and merge it once it moves to the buildpacks-community org. |
I just remove |
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
fbd8aac
to
f36bc66
Compare
@jjbustamante what's the reasoning for having both |
@hone I am pretty sure I followed some guidelines where the |
@tomkennedy513 are we ok with this PR? can we merge it? |
This Pull Request adds missing files to document CONTRIBUTORS.md file. This files are required as part of the process to migrate kpack into CNB.
See for more details.
Fixes #1135