Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for kpack CONTRIBUTORS.md #1149

Merged
merged 1 commit into from
May 23, 2023

Conversation

jjbustamante
Copy link
Contributor

This Pull Request adds missing files to document CONTRIBUTORS.md file. This files are required as part of the process to migrate kpack into CNB.

See for more details.

Fixes #1135

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #1149 (4642cb1) into main (bdf7d5a) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 4642cb1 differs from pull request most recent head 430f763. Consider uploading reports for the commit 430f763 to get more accurate results

@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
+ Coverage   70.01%   70.03%   +0.01%     
==========================================
  Files         132      132              
  Lines        6677     6671       -6     
==========================================
- Hits         4675     4672       -3     
+ Misses       1573     1570       -3     
  Partials      429      429              

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chenbh
Copy link
Contributor

chenbh commented Feb 21, 2023

Out of curiosity, @jjbustamante when do you want to merge this PR? Just wondering what happens when someone emails security@buildpacks.io between the merger of this PR and the actual handoff of kpack.

@samj1912
Copy link
Contributor

I believe we wanted to keep this PR open and merge it once it moves to the buildpacks-community org.

@jjbustamante
Copy link
Contributor Author

I just remove SECURITY.md from this PR and I will create another PR with just that file, I think we can then approved and merge this and left open the other one after we move to community org repo

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante force-pushed the enhancement/issue-1135-contributors-file branch from fbd8aac to f36bc66 Compare May 17, 2023 16:17
@hone
Copy link

hone commented May 17, 2023

@jjbustamante what's the reasoning for having both CONTRIBUTORS.md and CONTRIBUTING.md?

@jjbustamante
Copy link
Contributor Author

@hone I am pretty sure I followed some guidelines where the CONTRIBUTORS.md was some kind of index, and then the CONTRIBUTING.md. But I can remove it, no problem with that, we don't have it in any other CNB repos I think

@jjbustamante
Copy link
Contributor Author

@tomkennedy513 are we ok with this PR? can we merge it?

@tomkennedy513 tomkennedy513 merged commit 21404dd into main May 23, 2023
1 check passed
@tomkennedy513 tomkennedy513 deleted the enhancement/issue-1135-contributors-file branch May 23, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for kpack Contributors (CONTRIBUTORS.md file)
6 participants