Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Build resource documentation #1156

Merged
merged 1 commit into from
May 24, 2023

Conversation

jjbustamante
Copy link
Contributor

This PR adds some documentation to help understand users on how they achieved a similar outcome from a pack build using Build resource

Fixes #1130

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #1156 (c244eb0) into main (bdf7d5a) will decrease coverage by 2.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   70.01%   67.57%   -2.44%     
==========================================
  Files         132      132              
  Lines        6677     8004    +1327     
==========================================
+ Hits         4675     5409     +734     
- Misses       1573     2166     +593     
  Partials      429      429              

see 110 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samj1912
Copy link
Contributor

samj1912 commented Mar 4, 2023

@jjbustamante can we add some docs on how to rebuild/rebase with the build resource?

@jjbustamante
Copy link
Contributor Author

@jjbustamante can we add some docs on how to rebuild/rebase with the build resource?

Yeah, I will do that next week

@jjbustamante
Copy link
Contributor Author

@jjbustamante can we add some docs on how to rebuild/rebase with the build resource?

@samj1912 , I added some docs for rebuild and rebase, if can take a look it will be great

@hone
Copy link

hone commented May 16, 2023

@jjbustamante I noticed there is more than 1 kpack tutorial. What are your thoughts on moving this out the Build docs and into it's own tutorial? It'd still be great to reference it from there.

@jjbustamante
Copy link
Contributor Author

@jjbustamante I noticed there is more than 1 kpack tutorial. What are your thoughts on moving this out the Build docs and into it's own tutorial? It'd still be great to reference it from there.

I don't have problem with that, thinking about it, maybe we can add a link in the README, something like:

Screenshot 2023-05-17 at 8 18 50 AM

And keep the link in the build resource page.

@tomkennedy513 , @matthewmcnew any thoughts on this?

@tomkennedy513
Copy link
Collaborator

@jjbustamante I noticed there is more than 1 kpack tutorial. What are your thoughts on moving this out the Build docs and into it's own tutorial? It'd still be great to reference it from there.

I don't have problem with that, thinking about it, maybe we can add a link in the README, something like:

Screenshot 2023-05-17 at 8 18 50 AM

And keep the link in the build resource page.

@tomkennedy513 , @matthewmcnew any thoughts on this?

I think a separate file makes sense like @hone suggested

@jjbustamante
Copy link
Contributor Author

@tomkennedy513 @hone I just updated the PR, let me know how it looks now

@jjbustamante jjbustamante added the cnb-donation Required for the project to be donated to CNB community organization label May 24, 2023
@tomkennedy513
Copy link
Collaborator

@tomkennedy513 @hone I just updated the PR, let me know how it looks now

@jjbustamante Looks good! Can you just remove the WIP commits for this pr as well

adding links from README and build resource.

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante force-pushed the enhancement/issue-1130-build-resource branch from c244eb0 to 5b88355 Compare May 24, 2023 14:22
@jjbustamante
Copy link
Contributor Author

@tomkennedy513 @hone I just updated the PR, let me know how it looks now

@jjbustamante Looks good! Can you just remove the WIP commits for this pr as well

Done! @tomkennedy513

@tomkennedy513 tomkennedy513 merged commit 386d7a8 into main May 24, 2023
1 check passed
@tomkennedy513 tomkennedy513 deleted the enhancement/issue-1130-build-resource branch May 24, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cnb-donation Required for the project to be donated to CNB community organization documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation for Build resource
5 participants