Fix: Tests hanging on MacOS when testing error on phase (#244)

Signed-off-by: Javier Romero <jromero@pivotal.io>
buildpacks · Aug 6, 2019 · 5952513 · 5952513
1 parent d871331
commit 5952513
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/internal/archive/archive.go b/internal/archive/archive.go
@@ -38,7 +38,12 @@ func readAsTar(src, basePath string, uid, gid int, mode int64, writeFn func(tw *
 		}()
 
 		tw := tar.NewWriter(w)
-		defer tw.Close()
+		defer func() {
+			// only close if no errors have occurred
+			if err == nil {
+				tw.Close()
+			}
+		}()
 
 		err = writeFn(tw, src, basePath, uid, gid, mode)
 	}()