Move inspect-builder and inspect-buildpack to relevant subcommands #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/chore
Codecov Report
@@ Coverage Diff @@
## main #1071 +/- ##
==========================================
+ Coverage 80.38% 80.51% +0.13%
==========================================
Files 133 135 +2
Lines 8170 8221 +51
==========================================
+ Hits 6567 6618 +51
Misses 1174 1174
Partials 429 429
Flags with carried forward coverage won't be shown. Click here to find out more. |
dfreilich
commented
Feb 10, 2021
Comment on lines
+36
to
+39
| imageName := cfg.DefaultBuilder | ||
| if len(args) >= 1 { | ||
| imageName = args[0] | ||
| } |
There was a problem hiding this comment.
This was previously an undocumented feature. I've added it to the long description of the command now.
| buildpackName := args[0] | ||
| registry := flags.Registry | ||
| if registry == "" { | ||
| registry = cfg.DefaultRegistryName |
There was a problem hiding this comment.
This is a slight change of behavior – in inspect-builder, it checks the configs default-registry, rather than default-registry-name, but given that default-registry is deprecated, I thought it appropriate to use the newer default-registry-name for the updated command.
dfreilich
added a commit
that referenced
this pull request
Feb 15, 2021
* Remove trust-builder, untrust-builder, and list-trusted-builders acceptance tests (they are currently tested under the config when block * Move inspect-buildpack into the buildpack block, to allow for easier restructuring for #1071 Signed-off-by: David Freilich <dfreilich@vmware.com>
1 task
…uilder and inspect-buildpack commands * Rename inspect-image to inspect, and add alias for inspect-image * Change behavior for inspect-buildpack to look at default registry name in config, rather than deprecated default registry Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
dfreilich
force-pushed
the
920-inspect-command
branch
from
22693e8
to
c989332
Compare
github-actions
bot
added
the
type/chore
Signed-off-by: David Freilich <dfreilich@vmware.com>
dfreilich
force-pushed
the
920-inspect-command
branch
from
c989332
to
b7711d1
Compare
Signed-off-by: David Freilich <dfreilich@vmware.com>
dfreilich
commented
Mar 5, 2021
| last := len(parts) - 1 | ||
| cmdParts = append(cmdParts, parts[:last]...) | ||
| search = parts[last] | ||
| } else { |
There was a problem hiding this comment.
This change was to enable seeing whether pack supports a top-level command, which otherwise didn't work appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Output
Before
After
Documentation
Related
Resolves #920
Resolves #597 (finally)