-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pack builder create
should support extensions
#1478
Conversation
4e4e459
to
59cc426
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
- Coverage 81.12% 80.99% -0.13%
==========================================
Files 155 156 +1
Lines 10094 10281 +187
==========================================
+ Hits 8188 8326 +138
- Misses 1422 1458 +36
- Partials 484 497 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
59cc426
to
7798d96
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial feedback:
I like the term module overall for the generic shared concept. There are still a few references where “buildpacks” are used when talking about extensions though. I think they need to be fully resolved.
ie.
- BuildpackLayers
/pkg/buildpack
package
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Still to be done:
|
Signed-off-by: Natalie Arellano <narellano@vmware.com>
pack builder create
should support extensionspack builder create
should support extensions
9c472ff
to
ce45c52
Compare
Acceptance test expects different diffIDs for Linux and Windows layers Signed-off-by: Natalie Arellano <narellano@vmware.com>
ce45c52
to
4de7a85
Compare
- Acceptance test expects different diffIDs for Linux and Windows layers - Fix compat Signed-off-by: Natalie Arellano <narellano@vmware.com>
5165535
to
77da6cc
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
The code changed, so the diff ID changed Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
d5980cc
to
c9f8a54
Compare
d458bf9
to
d18d7da
Compare
This will make the diff easier to parse Signed-off-by: Natalie Arellano <narellano@vmware.com>
d18d7da
to
a3e426b
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Summary
If a builder.toml contains
[extensions]
and[order-extensions]
:Documentation
Related
Resolves #1468