Add support for Platform 0.10 #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix (restore): when gid is provided, it shouldn't override other flags Fix (analyze): when cache image is used, flags should not also contain -cache-dir Fix (restore): when cache image is used, flags should not also contain -cache-dir - Variable rename (ops for operations) Fix (restore): provide registry credentials when using a cache image Signed-off-by: Natalie Arellano <narellano@vmware.com>
- 0.10 is a supported platform and the default lifecycle is 0.15.0 - Run the extender when there are extensions Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
github-actions
bot
added
type/chore
natalieparellano
commented
Nov 8, 2022
Signed-off-by: Natalie Arellano <narellano@vmware.com>
- The sha changed with the removal of *.bat (as Windows is not supported) Signed-off-by: Natalie Arellano <narellano@vmware.com>
… needed - On platform 0.10, we can't determine the buildpack API so we don't know how to display the process args; this should be fixed in platform 0.11 Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
This is ready for review but needs to be re-pointed when |
…on is not running Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
platform-0.10
branch
from
e36292a
to
85056f3
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
platform-0.10
branch
from
85056f3
to
d548169
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
platform-0.10
branch
2 times, most recently
from
8734390
to
203bbd5
Compare
… perms on Linux Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
platform-0.10
branch
from
203bbd5
to
cc7c00b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
+ Coverage 80.99% 81.14% +0.15%
==========================================
Files 156 156
Lines 10284 10362 +78
==========================================
+ Hits 8329 8407 +78
Misses 1458 1458
Partials 497 497
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
We can't remove something that wasn't built Signed-off-by: Natalie Arellano <narellano@vmware.com>
dfreilich
approved these changes
Nov 20, 2022
| @@ -65,8 +65,8 @@ install: | |||
| cp ./out/$(PACK_BIN) ${DESTDIR}${BINDIR}/ | |||
|
|
|||
| mod-tidy: | |||
| $(GOCMD) mod tidy | |||
| cd tools && $(GOCMD) mod tidy | |||
| $(GOCMD) mod tidy -compat=1.17 | |||
There was a problem hiding this comment.
nit: I'm not sure whether we need to ensure we have compat with go1.17. I would be fine in a future release migrating to >= go1.19, unless there are specific reasons for us to remain below latest
| @@ -1,4 +1,4 @@ | |||
| api = "0.2" | |||
| api = "0.9" | |||
There was a problem hiding this comment.
Good catch, crazy we haven't bumped that version since!
| gopkg.in/warnings.v0 v0.1.2 // indirect | ||
| gopkg.in/yaml.v2 v2.4.0 // indirect | ||
| ) | ||
|
|
||
| go 1.17 | ||
|
|
||
| // Ensure compatibility with lifecycle/kaniko; match dependencies configured in: |
There was a problem hiding this comment.
Thanks for the note! Very helpful to have that added for the context
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds off of #1478 so will probably be easier to review when that is merged
Supersedes #1527 (but keep that one open until we release
packwith these changes as the docs PR points to #1527)Still a draft because:
pack inspectfor platform API >= 0.10Documentation
Related
Resolves #1469