Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Decouple Buildpack Plan and Bill-of-Materials #100

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

sclevine
Copy link
Member

@sclevine sclevine commented Jul 27, 2020

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine sclevine requested a review from a team as a code owner July 27, 2020 05:11
@nebhale nebhale requested a review from a team July 27, 2020 16:53
…nstead of args

Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
@sclevine
Copy link
Member Author

@ekcasey changes made as suggested

@nebhale nebhale requested a review from a team July 28, 2020 14:57
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>

Co-authored-by: Emily Casey <ecasey@vmware.com>
@nebhale nebhale requested a review from a team August 3, 2020 14:54
@nebhale
Copy link
Contributor

nebhale commented Aug 3, 2020

Final Comment Period with merge disposition, closing on 10 August, 2020.

@dfreilich
Copy link
Member

Would you mind clarifying the motivation behind this a bit more for me? Perhaps I don't understand the BOM usage as much as I thought I did, but why would you want to remove entries from it? Isn't it meant to provide an accurate assessment of everything that happened to the image?

@nebhale
Copy link
Contributor

nebhale commented Aug 5, 2020

@dfreilich There's a difference between "what's in an image" and "what was contributed by a buildpack". In some cases these overlap (e.g. the BellSoft Liberica Buildpack contributes a version of Java) and in others they don't (e.g. the user's application has these dependencies at these versions). As it stands now, if a buildpack wants to contribute to the BOM, it direct effects the execution of later buildpacks via the build plan. In addition, if a buildpack wants to affect other the execution of later buildpacks, it must modify the BOM. So the goal of this RFC is to say, these two things are separate from one another and should be populated as such.

nebhale added a commit that referenced this pull request Aug 11, 2020
[#100]

Signed-off-by: Ben Hale <bhale@vmware.com>
@nebhale nebhale merged commit 7efc5e9 into main Aug 11, 2020
@nebhale nebhale deleted the decouple-plan-and-bom branch August 11, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants