-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Extension Spec for Builder #116
Conversation
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my mind the big missing piece here is a API number or similar concept for builder images. An API number would allow us to change label schemas and file paths in an explicit and predictable way.
* Add reference to lifecycle descriptor file Signed-off-by: David Freilich <dfreilich@vmware.com>
Feedback from WG meeting (09/16):
I'll rework it using that feedback. |
* Add concept of versioning Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Is a file like |
@hone It came up here: #116 (comment). Consensus in WG was that it was |
* Spelling/grammar corrections * Move builder.api to its own Labels * Add drawback * Clarify spec changes Signed-off-by: David Freilich <dfreilich@vmware.com>
@buildpacks/core-team There were 2 open questions from @ekcasey I wanted to get feedback for:
|
Signed-off-by: David Freilich <dfreilich@vmware.com>
* Use CNB_X vars to define directories and allow maximum flexibility * Require SERVICE_BINDING_ROOT to be at CNB_PLATFORM_DIR/bindings Signed-off-by: David Freilich <dfreilich@vmware.com>
* Fix spelling * Specify that the env_dirs must correspond to a dir in the builder Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
FCP closing on 11/4 |
Readable