-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Descriptor Domains RFC #140
Conversation
Signed-off-by: Terence Lee <hone02@gmail.com>
84d8e04
to
5f11bab
Compare
Signed-off-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Terence Lee <hone02@gmail.com>
48a54ff
to
b4ac250
Compare
Feedback from @jromero during the platform subteam sync:
|
From WG today: need to solve the top level domain issue. By using |
I propose special casing the
Optionally, we forbid all TLD tables. This means that an org owning |
@jkutner as discussed in the WG, forbidding just TLDs doesn't really solve the problem b/c what if I have |
|
||
This suprsedes the [Project Descriptor Flexibility RFC](https://github.com/buildpacks/rfcs/pull/95). | ||
|
||
## Special Case Project Namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we could define that the root level of this TOML does not use reverse domain keys and move them under a generic config
(or similar) key. This would allow us to use descriptive keys for things that are generic (such as [project]
) and still allow folks using the .project
TLD to use this feature without workarounds.
This would also allow us to keep the build
key if we'd like to keep it.
Example:
[project]
id = ""
name = ""
# ...
[config.com.example]
awesome = "sauce"
I'm not sure how much I personally like this, but it seems to be a viable alternative.
Signed-off-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Terence Lee <hone02@gmail.com>
Signed-off-by: Terence Lee <hone02@gmail.com>
e5cd6fb
to
952bee5
Compare
Signed-off-by: Terence Lee <hone02@gmail.com>
@buildpacks/platform-maintainers - please create issues for this. (update parsing of |
@buildpacks/implementation-maintainers @buildpacks/distribution-maintainers needs issues |
@nebhale I see you added the |
@jromero to create issue and merge |
No description provided.