Rename PACK_ env vars to use CNB_ prefix instead #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
nebhale
approved these changes
Jan 21, 2019
|
Do we need to put deprecation stuff in the spec or since we're < |
|
Change at will for now. Some coordination is required the closer we get to 1.0 but no problem making breaking changes for now. |
|
And @hone can you please officially approve in the GitHub review feature? |
jkutner
approved these changes
Jan 24, 2019
nebhale
added a commit
to buildpacks/libbuildpack
that referenced
this pull request
Jan 29, 2019
This change updates the code to examine CNB_ environment variables instead of PACK_ environment variables. Where PACK_ was previously used, it still exists as a fallback to be removed once the lifecycle has been updated and released. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
nebhale
added a commit
to cloudfoundry/libcfbuildpack
that referenced
this pull request
Jan 29, 2019
This change updates dependencies to support CNB_ environment variables. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
nebhale
added a commit
to cloudfoundry/openjdk-cnb
that referenced
this pull request
Jan 29, 2019
This change updates dependencies to support CNB_ environment variables. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
nebhale
added a commit
to cloudfoundry/jvm-application-cnb
that referenced
this pull request
Jan 29, 2019
This change updates dependencies to support CNB_ environment variables. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
nebhale
added a commit
to cloudfoundry/build-system-cnb
that referenced
this pull request
Jan 29, 2019
This change updates dependencies to support CNB_ environment variables. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
nebhale
added a commit
to cloudfoundry/debug-cnb
that referenced
this pull request
Jan 29, 2019
This change updates dependencies to support CNB_ environment variables. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
nebhale
added a commit
to cloudfoundry/jmx-cnb
that referenced
this pull request
Jan 29, 2019
This change updates dependencies to support CNB_ environment variables. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
nebhale
added a commit
to cloudfoundry/azure-application-insights-cnb
that referenced
this pull request
Jan 29, 2019
This change updates dependencies to support CNB_ environment variables. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
nebhale
added a commit
to cloudfoundry/google-stackdriver-cnb
that referenced
this pull request
Jan 29, 2019
This change updates dependencies to support CNB_ environment variables. [buildpacks/spec#38] Signed-off-by: Ben Hale <bhale@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.