Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for extract line numbers in metrics #1781

Merged
merged 3 commits into from
May 24, 2024

Conversation

Xiangs18
Copy link
Collaborator

No description provided.

@Xiangs18
Copy link
Collaborator Author

@shahzebsiddiqui I am not sure why URL check failed. Docs was built successful though.

@shahzebsiddiqui
Copy link
Member

@shahzebsiddiqui I am not sure why URL check failed. Docs was built successful though.

dont worry too much about the urlcheck sometimes they come and go and if its persistent issue then we need to fix it. It good practice to check the urlcheck and then navigate to website. The urlcheck has a timeout and retry limit you can take a look at https://github.com/buildtesters/buildtest/blob/devel/.github/workflows/urlchecker.yml for more details. I typically update the urls or fix them if its a known issue. Sometimes websites go down or url gets changed over time.

@shahzebsiddiqui
Copy link
Member

@Xiangs18 i was looking at the first example, i think you should update the buildspec to remove linenum_to_stderr that one is not being used for anything and is not being described in the text above. I think we had this buildspec from the regression test perspective to capture stderr as well.
Screenshot 2024-05-22 at 10 39 53 AM

… add output of buildtest build and buildtest inspect query
@pull-request-size pull-request-size bot added size/M and removed size/S labels May 22, 2024
@Xiangs18
Copy link
Collaborator Author

fixed, this PR is ready to merge.

@shahzebsiddiqui
Copy link
Member

thanks @Xiangs18 this looks good! I will merge this in

@shahzebsiddiqui shahzebsiddiqui merged commit cc04b6e into devel May 24, 2024
23 checks passed
@shahzebsiddiqui shahzebsiddiqui deleted the dev-doc_extract branch May 24, 2024 13:32
@shahzebsiddiqui shahzebsiddiqui linked an issue Jun 12, 2024 that may be closed by this pull request
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants