Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 Directory support #397

Merged
merged 6 commits into from
Mar 29, 2023
Merged

FDC3 Directory support #397

merged 6 commits into from
Mar 29, 2023

Conversation

johnman
Copy link
Member

@johnman johnman commented Mar 29, 2023

Added ability to:

specify apps in:

  • FDC3 1.2 app directory format (using customConfig for additional platform specific settings)
  • FDC3 2.0 app directory format (using hostManifests setting for platform specific settings)
  • Updated our custom format to support an interop setting vs an intents array (both are populated at the moment for backwards compatibility)

Also updated the broker to return the right getInfo response based on whether the client is fdc3 1.2 or 2.0 and did the same for the findIntent and findIntentByContext app meta data response that come alongside the intent(s) found.

At this time the platform is pretty complaint. There are two opinionated pieces of the platform:

  • the fdc3 open api does work but an app has to opt into it working by specify intent support for an Intent called OpenApp. They can then register an intent handler for that intent in order to receive the context.
  • the apps returned by findIntent and findIntentByContext do not include instances (awaiting feedback on this). The reason for this is that this could be expensive if you have a lot views/windows as we generate rich app meta data for instances and it seems wasteful to collect all of that in case someone needs it. If someone wants a list of all instances there is the fdc3.findInstances api and if they wish to gather additional meta data for each instance (or a specific instance) they can use the fdc3.getAppMetadata api. This is more efficient.

made the app url/endpoint handling more robust and now have app sources as directories. Directories manage fetching from endpoints and the app manages the apps that are returned from all directories.
…s and findIntentsByContext

GetAppMetadata only exists in fdc3 2.0+ so right now doesn't need logic to check api version.
@johnman johnman requested a review from obany March 29, 2023 08:05
Copy link
Contributor

@obany obany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments

@johnman johnman merged commit 33bdbb0 into workspace/v12.0.0 Mar 29, 2023
@obany obany deleted the dev/john/fdc3-directory branch March 29, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants