lib:simulations:Merge_sort :Merge Sort implemented #174 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yashugarg please merge this PR. |
yashlamba
requested changes
May 24, 2021
Comment on lines
+198
to
+207
| onPressed: () { | ||
| pause = !pause; | ||
| //TODO: Fix the bug, i.e, when we pause the code shows unusual behaviour | ||
| if (!sort) | ||
| _sort(); | ||
| else | ||
| setState(() { | ||
| sort = false; | ||
| }); | ||
| }, |
There was a problem hiding this comment.
The pause bug needs to be fixed, when paused, it restarts the sort.
There was a problem hiding this comment.
Yes, it actually scans the array from the starting and I tried making some other changes but I wasn't able to implement the pause function properly.
Hopefully, someone else will be able to resolve this issue. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yashugarg I've added Merge algorithm simulation for solving the issue #174 , it works fine.