feat(Field): adding data-auto-ids to the new novo-field elements (#1349)

* feat(Field): trying out a way to add data-auto-ids to the new novo-field elements * adding/changing field auto ids * using label instead of value
bullhorn · Nov 4, 2022 · 4cb454b · 4cb454b
1 parent 1504e0f
commit 4cb454b
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/projects/novo-elements/src/elements/field/field-control.ts b/projects/novo-elements/src/elements/field/field-control.ts
@@ -10,6 +10,7 @@ export abstract class NovoFieldControl<T> {
 
   /** The last key pressed. */
   lastKeyValue: string | null;
+
   /** The last cursor position. */
   lastCaretPosition: number | null;
 

diff --git a/projects/novo-elements/src/elements/field/field.ts b/projects/novo-elements/src/elements/field/field.ts
@@ -118,7 +118,6 @@ export class NovoFieldElement implements AfterContentInit, OnDestroy {
     this._validateControlChild();
 
     const control = this._control;
-
     if (control.controlType) {
       this._elementRef.nativeElement.classList.add(`novo-field-type-${control.controlType}`);
       this._elementRef.nativeElement.setAttribute('data-control-type', control.controlType);
@@ -128,6 +127,10 @@ export class NovoFieldElement implements AfterContentInit, OnDestroy {
       this._elementRef.nativeElement.setAttribute('data-control-id', control.id);
     }
 
+    if (control.ngControl?.name) {
+      this._elementRef.nativeElement.setAttribute('data-control-key', control.ngControl.name);
+    }
+
     // Subscribe to changes in the child control state in order to update the form field UI.
     // tslint:disable-next-line:deprecation
     control.stateChanges.pipe(startWith(null)).subscribe(() => {

diff --git a/...-elements/src/elements/query-builder/condition-definitions/picker-condition.definition.ts b/...-elements/src/elements/query-builder/condition-definitions/picker-condition.definition.ts
@@ -18,7 +18,7 @@ import { AbstractConditionFieldDef } from './abstract-condition.definition';
       <novo-field *novoConditionInputDef="let formGroup; fieldMeta as meta" [formGroup]="formGroup">
         <novo-select formControlName="value" [placeholder]="labels.select" [multiple]="true">
           <!-- WHat about optionUrl/optionType -->
-          <novo-option *ngFor="let option of meta?.options" [value]="option.value">
+          <novo-option *ngFor="let option of meta?.options" [value]="option.value" [attr.data-automation-value]="option.label">
             {{ option.label }}
           </novo-option>
         </novo-select>