feat(Field): adding data-auto-ids to the new novo-field elements #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 17fc658): https://novo-elements--pr1349-field-auto-ids-mlo54gne.web.app (expires Mon, 26 Sep 2022 21:10:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
ndickerson
approved these changes
Nov 1, 2022
hiqbal01
approved these changes
Nov 4, 2022
MichaelDill
pushed a commit
that referenced
this pull request
Nov 29, 2022
* feat(Field): adding data-auto-ids to the new novo-field elements (#1349) * feat(Field): trying out a way to add data-auto-ids to the new novo-field elements * adding/changing field auto ids * using label instead of value * feat(dateTimePicker): Added formatter for dateTimePicker (#1361) * Added formatter for dateTimePicker * Small fix * exported date-time format * Added military date-time picker * Removed military time demo * feat(QueryBuilder): adding isNull/isEmpty operators to query builder field definitions (#1358) * feat(QueryBuilder): adding isEmpty operator to query builder field definitions * fix: removing unused imports * fix(): changing non-string isEmpty operatators to isNull * fix(xmldom): removed unused xmldom dependency due to security concern (#1357) * fix(xmldom): updated xmldom dependency to address security concern * removing xmldom altogether since it is unused * chore(deps): bump loader-utils from 1.4.0 to 1.4.1 (#1362) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.1/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump loader-utils from 1.4.1 to 1.4.2 (#1366) chore(deps): bump loader-utils from 1.4.0 to 1.4.2 Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.0...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dan Voegelin <dvoegelin@bullhorn.com> * fix(NovoDataTableSortButton): fixing ng14 warning caused by animating pointer-events (#1368) * feat(date-time-condition): Added default date-time condition definition (#1364) * Added date time picker to query builder Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Kurt McGallion <kurt.mcgallion@bullhorn.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if a field has an ngControl, it looks like we can pull the name of the control to use as the data-automation-id.
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots