Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] - Improvements to the Select Footer #72

Closed
jgodi opened this issue Jun 16, 2016 · 1 comment
Closed

[Select] - Improvements to the Select Footer #72

jgodi opened this issue Jun 16, 2016 · 1 comment
Assignees
@escarre
Milestone
Cross-Browser Com...

Comments

@jgodi
Copy link
Contributor

jgodi commented Jun 16, 2016

Footer should just be another

  • tag.

    Also, the text "+ ADD NEW ITEM" is not visually centered inside the footer.

    When toggling the "ADD NEW" the footer renders off screen, making me scroll down to save. Possible to not have it scroll when showing the input?

    The "Save/Cancel" should be added to the https://github.com/bullhorn/novo-elements/blob/master/src/services/novo-label-service.js, then you can inject that into Select and use {{labels.save}} instead of the plain text. This is used to localize it else where. Or you can get around that by having the save/cancel come from the config too.

    		•
    @jgodi jgodi added the bug label Jun 16, 2016
    @jgodi
    Copy link
    Contributor Author

    jgodi commented Jun 16, 2016

    @escarre

    escarre added a commit to escarre/novo-elements that referenced this issue Jun 25, 2016
    @escarre
    fix(Select) : Clean up select footer, convert to header for UX/ease-o…
    5ccda4e 
    …f-use

Fix issue bullhorn#72.

Breaking Changes: Renames Select footerConfig to Select headerConfig
    @escarre escarre mentioned this issue Jun 25, 2016
    Merged
    7 tasks
    @jgodi jgodi changed the title Improvements to Select Footer [Select] - Improvements to the Select Footer Jun 26, 2016
    @jgodi jgodi added this to the Cross-Browser Compatibility milestone Jun 26, 2016
    escarre added a commit that referenced this issue Jun 28, 2016
    @escarre
    fix(Select) : Clean up select footer, convert to header for UX/ease-o…
    ed36036 
    …f-use

Fix issue #72.

Breaking Changes: Renames Select footerConfig to Select headerConfig
    escarre added a commit to escarre/novo-elements that referenced this issue Jun 28, 2016
    @escarre
    fix(Select) : Clean up select footer, convert to header for UX/ease-o…
    2916e20 
    …f-use

Fix issue bullhorn#72.

Breaking Changes: Renames Select footerConfig to Select headerConfig
    escarre added a commit that referenced this issue Jun 28, 2016
    @escarre
    fix(Select) : Clean up select footer, convert to header for UX/ease-o…
    237dd2e 
    …f-use

Fix issue #72.

Breaking Changes: Renames Select footerConfig to Select headerConfig
    escarre added a commit to escarre/novo-elements that referenced this issue Jun 28, 2016
    @escarre
    fix(Select) : Clean up select footer, convert to header for UX/ease-o…
    a5bf1a6 
    …f-use

Fix issue bullhorn#72.

Breaking Changes: Renames Select footerConfig to Select headerConfig
    @jgodi jgodi closed this as completed Jun 28, 2016
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @escarre escarre

    Labels
    None yet
    Projects
    None yet
    Milestone
    Cross-Browser Compatibility
    Development

    No branches or pull requests
    2 participants
    @jgodi @escarre