fix(Select) : Clean up select footer, convert to header for UX/ease-o… #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into the failed tests on my end, probably didn't set something up right :( |
|
For this to work now, you will have to add the following to
since we are injecting that LabelService now. |
| @@ -11,6 +11,8 @@ export class NovoLabelService { | |||
| quickNoteEmpty = 'No results to display...'; | |||
| required = 'Required'; | |||
| numberTooLarge = 'Number is too large'; | |||
| selectHeaderSave = 'Save'; | |||
There was a problem hiding this comment.
Can we make these more generic. aka save and cancel
escarre
force-pushed
the
bug/select-footer
branch
3 times, most recently
from
2916e20
to
237dd2e
Compare
| <input autofocus type="text" [placeholder]="headerConfig.placeholder" [attr.id]="name" autocomplete="false" [(ngModel)]="header.value" [ngClass]="{invalid: !header.valid}"/> | ||
| <footer> | ||
| <button (click)="toggleHeader($event, false)">{{labels.selectHeaderCancel}}</button> | ||
| <button (click)="saveHeader()" class="primary">{{labels.selectHeaderSave}}</button> |
…f-use Fix issue bullhorn#72. Breaking Changes: Renames Select footerConfig to Select headerConfig
escarre
force-pushed
the
bug/select-footer
branch
from
237dd2e
to
a5bf1a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes requested in Issue #72 . It also moves the footer from the base of the select list to the top - with the possibility of a long list, a user might not scroll to the bottom or be aware of the 'Add New Item' capability.
What did you change?
Reviewers
@jgodi
Checklist (completed via merger)
…f-use
Fix issue #72.
Breaking Changes: Renames Select footerConfig to Select headerConfig