feat(): next #1551
Merged
feat(): next #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(Criteria Builder): Add criteria builder types and tests
…ards compatability
* test(Control): increase code coverage for Control * test(Control): Cover more branches for Control * Add another test
…fixes (#1536) * feat(TabbedGroupPicker): updating selector for getting pixel height and reducing maxWidth * removing unused title inputs from demo * passing key events to dropdown and clearing filter on toggle * adding keydown handler to search box too
Addressses all known issues from previous attempts at the same change, and adds further testing
* fix(Criteria): Added criteria operator types * fix(Criteria): More types * fix(Criteria): Enforcing types * fix(Criteria): Updating imports * fix(Criteria): Fixing type * fix(Criteria): Updating Type * fix(Criteria): Updating Types to be backwards compatible --------- Co-authored-by: Nathan Dickerson <nathan.dickerson@bullhorn.com>
Co-authored-by: Nathan Dickerson <nathan.dickerson@bullhorn.com>
…onent (#1543) * feat(TabbedGroupPicker): focusing on the input when opening the dropdown * feat(TabbedGroupPicker): adding option to hide left tab column * hiding left column via css instead * undoing hide tabs code * feat(TabbedGroupPicker): adding optional footer with apply/cancel buttons * reordering ng-content
|
Visit the preview URL for this PR (updated for commit 880c27e): https://novo-elements--pr1551-next-bsd1rlsr.web.app (expires Fri, 28 Jun 2024 15:22:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
…o be self-hosted (#1544) Allow the single Condition Builder component to be instantiated directly, and specify a default staticFieldSelection
…boxes (#1549) New event on items that have been activated Add keyboard actions on TabbedGroupPicker
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ws](https://github.com/websockets/ws) from 8.16.0 to 8.17.1. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.16.0...8.17.1) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(TabbedGroupPicker): some updates to the tabbed group picker component #1543
fix(CriteriaTypes): Adding missing operator types #1547
feat(Chips): allow novo-chip size input via novo-chips #1548
feat(CriteriaBuilder): Allow the single Condition Builder component to be self-hosted #1544
feat(TabbedGroupPicker): Added option to disable item selection/checkboxes #1549
chore(deps-dev): bump braces from 3.0.2 to 3.0.3 #1553
chore(deps-dev): bump ws from 8.16.0 to 8.17.1 #1557
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots