Support ComponentActivity for Jetpack Compose template projects #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vity that is backed by ComponentActivity instead of AppCompatActivity
LachlanMcKee
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace ActivityIntegrationPoint dependency on AppCompatActivity with Activity
Add NodeComponentActivity as a drop-in replacement for NodeActivity in projects using ComponentActivity
Note: ComponentActivity provides as
registerForActivityResult()api that deprecatesonActivityResult()andonRequestPermissionsResult(), but I've deemed implementing a solution for supporting that new result api beyond the scope of this PR.Fixes #131
Check list
CHANGELOG.mdif required.