Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed MutableNodeCustomisationDirectory non-lazy functions #393

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

LachlanMcKee
Copy link
Collaborator

Description

Removed MutableNodeCustomisationDirectory non-lazy functions

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

@LachlanMcKee LachlanMcKee force-pushed the removed-non-lazy-customsation-logic branch 3 times, most recently from 344bb09 to a3db182 Compare April 5, 2023 16:00
@LachlanMcKee LachlanMcKee force-pushed the removed-non-lazy-customsation-logic branch from a3db182 to 3016816 Compare April 5, 2023 17:22
@LachlanMcKee
Copy link
Collaborator Author

@KovalevAndrey I had to revert the change to getSubDirectory as it turns out Appyx itself is using a different key type to the NodeCustomisationDirectory. Mind taking another look?

@LachlanMcKee LachlanMcKee force-pushed the removed-non-lazy-customsation-logic branch from 3016816 to 1772ea8 Compare April 6, 2023 12:07
@LachlanMcKee LachlanMcKee force-pushed the removed-non-lazy-customsation-logic branch from 1772ea8 to 5d08c60 Compare April 6, 2023 12:54
@LachlanMcKee LachlanMcKee merged commit dc2f8c9 into 1.x Apr 11, 2023
@LachlanMcKee LachlanMcKee deleted the removed-non-lazy-customsation-logic branch April 11, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants