Extract some useful classes and simplify Glide.with().using() usage #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation: which already diverged).
Closed
Make library compile/test/checkstyle on Windows (@ignore in comments where needed) Make the SVG sample a functional app. Fix version number and format of build.gradle Remove unintended file and replace with proper scripts. Review: Remove unnecessary check
…ource.get() results.
This reverts commit be7dd31.
|
LGTM. I'll test and try to merge tonight or tomorrow morning. Thanks! |
|
Rebased onto master starting here: 1e5d51a. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change is (32fccfb):
Make the engine require only the dependencies it will use based on
DiskCacheStrategy.See 0dad499 for the effect it has on usage.