Add Glide.setModulesEnabled API for 3.x to allow apps to disable Manifest parsing #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjudd
approved these changes
Feb 24, 2017
| @@ -137,6 +139,21 @@ public static File getPhotoCacheDir(Context context, String cacheName) { | |||
| } | |||
|
|
|||
| /** | |||
| * Enable or disable the parsing of AndroidManifest.xml | |||
| * looking for {@link GlideModule} implementations. | |||
There was a problem hiding this comment.
Line break is a little early here.
|
Thanks! |
|
Is there a snapshot build in maven anywhere that has this fix? as far as I can tell, https://oss.sonatype.org/content/repositories/snapshots/com/github/bumptech/glide/glide/3.8.0-SNAPSHOT/ is pretty out of date. If not, I can always build myself. |
|
Not totally sure how this works, but it appears that there are snapshots built from 2/25 in that same folder: https://oss.sonatype.org/content/repositories/snapshots/com/github/bumptech/glide/glide/3.8.0-SNAPSHOT/glide-3.8.0-20170225.215140-15.jar It looks like it also keeps around a few older versions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a static flag to Glide to disable parsing the manifest to find configured modules.
Added unit tests.
Same as #1753 but backported to 3.0 branch
Fixes #684
Motivation and Context
he Dropbox app has been crashing on launch approximately 9000 times a day due to RuntimeExceptions thrown by PackageManager. We'd like to remove the dependency on PackageManager from our startup path, and we don't use any GlideModules. While #1742 in 4.0 will address this long term, we'd like a short term way to run Glide without runtime manifest parsing.
In order to enable unit testing, I decided to make this a set method that takes a boolean.