Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat optionals #51

Merged
merged 18 commits into from
Jul 9, 2022
Merged

Feat optionals #51

merged 18 commits into from
Jul 9, 2022

Conversation

wirthual
Copy link
Member

Draft for merging all optional packages into the Deutschland package.

This probably needs a bit of testing before it can be released.

  • Should we make all subpackages optional? This is how it is now with deutschland[all] all packages will get installed
  • This might be a breaking change, since an update will probably remove packages which were part of the package before (not tested yet)
  • How is the version resolving? Does it take super long everywhere? Or only with poetry and on my machine?
  • Can we make the package with tensorflow as dependency also optional and independent of the deutschland package? Thats a huge dependency.

@LilithWittmann let me know what you think 👍

@LilithWittmann
Copy link
Member

Looks generally good to me. I'm not sure about the update strategy.

@severinsimmler
Copy link
Contributor

severinsimmler commented Mar 22, 2022

How is the version resolving? Does it take super long everywhere? Or only with poetry and on my machine?

It's considered best practice to just commit the poetry.lock by the way. With the poetry.lock, Poetry won't have to resolve all dependencies if you do a fresh install, but just install what's in the lockfile.

@wirthual wirthual marked this pull request as ready for review May 10, 2022 03:06
@wirthual
Copy link
Member Author

I deleted the failing tests for now. Ready to merge from my side.

@wirthual wirthual changed the title Feat optionals Draft: Feat optionals May 20, 2022
@wirthual wirthual changed the title Draft: Feat optionals Feat optionals May 21, 2022
@LilithWittmann
Copy link
Member

@wirthual should we try to merge this?

@LilithWittmann LilithWittmann merged commit d843f33 into bundesAPI:main Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants