Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor bundesanzeiger module and config to work concurect… #87

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

FelixBehne
Copy link

Hey, while using the Bundesanzeiger module, I noticed some issues that I want to fix with this pull request for everyone.

  • I introduced concurrency to improve the script's performance by up to 300%. This should make it faster and more efficient when searching for reports.
  • I added a progress bar and more user feedback to make the module less opaque and more user-friendly. You'll now have a better understanding of what's happening behind the scenes.
  • I optimized the overall code quality and documentation to make it easier to read and maintain.
  • Additionally, I've included new functions to extract interesting data from reports and visualize them. While these functions may not work for every company, I believe they will be useful for many users.

I hope you find these improvements helpful and valuable. Thank you for considering this pull request ;)

…ly (performance gain of up to 300%), add utility functions and increase overall performance and fault tolerancy of code
@wirthual
Copy link
Member

wirthual commented Apr 17, 2023

Hi,

Thanks so much for your contribution. Great work 👏

I need some time for a deeper look. But from what I can tell from a quick look you used type hints which require python 3.10. (e.g dict)

We should keep the min python version the same if possible.

@wirthual
Copy link
Member

HI @FelixBehne ,

Would you mind merging back main into your branch? I guess the import order changed due to isort.

@wirthual
Copy link
Member

wirthual commented Jul 6, 2023

Hi @FelixBehne ,

I merged back the current master. I included the changes for raw_report which was added in the meantime. Also I changed the code to be compatible with Python 3.8.

Would you mind looking over the merged changes if you see any problems due to the merge?

I would really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants