Create standalone bundler/setup.rb at a consistent path. #4274
Conversation
glennpratt
force-pushed
the
standalone-bundler-path
branch
2 times, most recently
from
5826b07
to
5652525
Compare
|
👍 @indirect r? |
| def sys_exec(cmd, expect_err = false) | ||
| Open3.popen3(cmd.to_s) do |stdin, stdout, stderr, wait_thr| | ||
| def sys_exec(cmd, expect_err = false, popen_opts = {}) | ||
| Open3.popen3(cmd.to_s, popen_opts) do |stdin, stdout, stderr, wait_thr| |
There was a problem hiding this comment.
this seems to be failing on 1.8.7
There was a problem hiding this comment.
😿
I started using that pattern because I was getting warnings about nested chdir blocks. I can probably just avoid using the blocks. I might not get back to this till next week though.
There was a problem hiding this comment.
you can definitely nest chdir blocks -- the issue is probably with threads or something?
There was a problem hiding this comment.
Yep, I didn't actually look into where threads were coming from, but when I wrapped some of the examples in chdir I got warnings. I'm sure I can work around it.
|
👍 from me |
|
☔ The latest upstream changes (presumably #4283) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@glennpratt if you can rebase this and get it passing on 1.8, I think it's good to merge. |
|
@glennpratt ping on this? |
|
Sorry, been pretty busy with other things. I'll probably get to this next week. |
glennpratt
force-pushed
the
standalone-bundler-path
branch
from
5652525
to
46bbec2
Compare
| @@ -61,6 +82,21 @@ | |||
| end | |||
| end | |||
|
|
|||
| describe "with gem that has an invalid gemspec", :realworld => true do | |||
There was a problem hiding this comment.
Marking this existing test as :realworld.
glennpratt
force-pushed
the
standalone-bundler-path
branch
from
46bbec2
to
33922d7
Compare
…valid-gemspec-for-dependency Add helpful invalid gemspec error message for `bundle install --standalone`
|
@segiddins @indirect updated. Not sure I can take the blame for the SSL fails on |
glennpratt
force-pushed
the
standalone-bundler-path
branch
2 times, most recently
from
7678d9b
to
d0c282a
Compare
|
☔ The latest upstream changes (presumably #4377) made this pull request unmergeable. Please resolve the merge conflicts. |
glennpratt
force-pushed
the
standalone-bundler-path
branch
from
d0c282a
to
0ba8444
Compare
|
@homu r+ |
|
📌 Commit 0ba8444 has been approved by |
Create standalone bundler/setup.rb at a consistent path. While chasing a threading / chdir bug in #4264, I discovered `bundler/setup.rb` isn't written to a proper directory when run in a subdirectory and binstubs don't work (#4264 (comment)). This changes that so `bundler/setup.rb` is written relative to `Bundler.root` instead of `cwd` and expands test coverage a bit.
|
☀️ Test successful - status |
While chasing a threading / chdir bug in #4264, I discovered
bundler/setup.rbisn't written to a proper directory when run in a subdirectory and binstubs don't work (#4264 (comment)).This changes that so
bundler/setup.rbis written relative toBundler.rootinstead ofcwdand expands test coverage a bit.