Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Add helpful invalid gemspec error message for bundle install --standalone #4283

Merged
merged 1 commit into from
Feb 8, 2016
Merged

Add helpful invalid gemspec error message for bundle install --standalone #4283

merged 1 commit into from
Feb 8, 2016

Conversation

RochesterinNYC
Copy link
Contributor

Output whould now be:

$ bundle install --standalone
Using mono_logger 1.1.0
Using multi_json 1.11.2
Using rack 1.6.4
Using redis 3.2.2
Using tilt 2.0.2
Using thread_safe 0.3.5
Using bundler 1.12.0.pre
Using rack-protection 1.5.3
Using vegas 0.1.11
Using redis-namespace 1.5.2
Using tzinfo 1.2.2
Using sinatra 1.4.7
Using rufus-scheduler 2.0.24
Using resque 1.24.1
Using resque-scheduler 2.2.0
You have one or more invalid gemspecs that need to be fixed.
resque-scheduler 2.2.0 has an invalid gemspec

# This is a static string intentionally. It's interpolated at a later time.
begin
next if spec.name == "bundler"
Array(spec.require_paths).map do |path|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would extract out getting spec.require_paths and handle the exception there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gem_path is where the exception is occurring, but I see your point regarding moving the exception handling down a level/method call.

--standalone` when a gem/dependency has an invalid gemspec
@indirect
Copy link
Member

indirect commented Feb 8, 2016

Thanks!

indirect added a commit that referenced this pull request Feb 8, 2016
…valid-gemspec-for-dependency

Add helpful invalid gemspec error message for `bundle install --standalone`
@indirect indirect merged commit a753d01 into rubygems:master Feb 8, 2016
@segiddins
Copy link
Member

@indirect homu, please

homu added a commit that referenced this pull request Mar 22, 2016
…or-spec, r=segiddins

Create invalid gemspec error message spec that runs locally

- Move invalid gemspec spec involving `resque-scheduler 2.2.0` created in
  #4283 to realworld specs
- Related to [comments here](a753d01#commitcomment-16716088)
@coilysiren coilysiren modified the milestone: Release Archive Oct 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants