This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #4283 from RochesterinNYC/improve-error-message-in…
…valid-gemspec-for-dependency Add helpful invalid gemspec error message for `bundle install --standalone`
- Loading branch information
Showing
2 changed files
with
17 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -303,4 +303,18 @@ | |
expect(extension_line).to eq "$:.unshift File.expand_path '../../bundle', __FILE__" | ||
end | ||
end | ||
|
||
describe "with gem that has an invalid gemspec" do | ||
before do | ||
install_gemfile <<-G, :standalone => true | ||
source 'https://rubygems.org' | ||
gem "resque-scheduler", "2.2.0" | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
indirect
Author
Member
|
||
G | ||
end | ||
|
||
it "outputs a helpful error message" do | ||
expect(out).to include("You have one or more invalid gemspecs that need to be fixed.") | ||
expect(out).to include("resque-scheduler 2.2.0 has an invalid gemspec") | ||
end | ||
end | ||
end |
Are we using live rubygems intentionally here? I noticed this test failing or being slow.
I tried to make this a fake invalid gem with build_gem and failed 😄.