Timeouts and HEAD requests for file downloads #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #749 and replaces #748
This will add a global default download timeout of 60s. Not having a timeout there before is problematic enough that I don't care about backwards compatibility here. I doubt anyone relies on bw blocking forever. If for some reason a downloaded file needs a longer timeout (because it takes time to generate it server-side for example), this can now be addressed at item level with the new
download_timeoutattribute.Also if
content_hashis not set for a download file item, the URL will only be checked with a HEAD request instead of downloading the complete file just to throw it away.