Shmem3c: auth update for memmgr change #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r restart reader/writer versions of mapped files are now persisted in a file and will be used on (re)start of memmer. some more initial states and related methods were added.
this can fail if the data were corrupted, and it's not good to let the thread die due to the exception. we now catch this and try to re-create a new segment, or at least report the error to the main thread.
also completed other small TODOs, mainly documentation.
…when not. This can happen in normal initialization, i.e., both the authoritative server and the memory manager just starts. This initial reset command is just for segment reader modules to be synchronized with the memory manager, and the actual reset will be delayed until the memory manager completes building the segment data with any un-applied updates.
this will be needed if memmgr fails to initialize the segment data on restart, while reader modules are currently somehow using the segment. in this case memmgr will send a segment info update to reset the segment for synchronization, and, as a result, readers will fail to use the segment until it's fixed. that's not good, but this should be a rare erroneous condition and should be acceptable.
this can happen due to DB locking if DDNS is heavily updating it. it now also catches an exception from install(). this can happen if the locking issue happens in the delayed apply of zone diffs.
… shmem3 Fixed Conflicts: src/lib/python/bundy/memmgr/tests/builder_tests.py
jinmei
added a commit
that referenced
this pull request
Jun 7, 2014
Shmem3c: auth update for memmgr change
|
merging to move forward. I'll create separate issues for the outstanding review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also an incremental update. the actual change is bbb94be and e89181e (the latter is a small fix, not directly related to the main change).