Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sandbox API key procedure (bunq/sdk_csharp#101) #102

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

sandervdo
Copy link
Contributor

This PR closes/fixes the following issues:

@sandervdo sandervdo self-assigned this Jun 11, 2018
@sandervdo sandervdo requested a review from OGKevin June 11, 2018 20:21
@OGKevin OGKevin added this to the 1.0.0 milestone Jun 12, 2018
@OGKevin OGKevin added this to To do in 1.0.0 - SDK via automation Jun 12, 2018
@OGKevin OGKevin moved this from To do to In progress in 1.0.0 - SDK Jun 12, 2018
@OGKevin OGKevin moved this from In progress to open PR in 1.0.0 - SDK Jun 12, 2018
README.md Outdated
@@ -11,7 +11,8 @@ Now you can build even bigger and better apps and integrate them with your bank

Before you dive into this brand new SDK, please consider:
- Checking out our new developer’s page [https://bunq.com/en/developer](https://bunq.com/en/developer) 🙌
- Grabbing your production API key from the bunq app or asking our support for a Sandbox API key 🗝
- Grabbing your production API key from the bunq app or generate a Sandbox API key using the
[Tinker endpoint](https://together.bunq.com/topic/tinker-the-api) 🗝
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, ...key using tinker

@sandervdo
Copy link
Contributor Author

@OGKevin pushed.

@OGKevin
Copy link
Contributor

OGKevin commented Jun 14, 2018

@sandervdo your first commit message is missing . :P but ill merge it no sweat.

@OGKevin OGKevin merged commit 4719702 into develop Jun 14, 2018
1.0.0 - SDK automation moved this from open PR to merged Jun 14, 2018
@OGKevin OGKevin deleted the sandbox-api-key-procedure branch June 14, 2018 19:27
@OGKevin
Copy link
Contributor

OGKevin commented Jun 14, 2018

@sandervdo

@sandervdo
Copy link
Contributor Author

@OGKevin didn't you mean to tag Andre or sth? As for the period, isn't that a bit of a waste of characters? There's a limit on the amount of characters that are shown on GitHub anyway, the remainder is cut off to the description part (that's why I missed it I guess) 😋

@OGKevin
Copy link
Contributor

OGKevin commented Jun 15, 2018

@andrederoos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.0.0 - SDK
  
merged
Development

Successfully merging this pull request may close these issues.

Update Sandbox API key procedure
2 participants