Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added net standard 2 support. (bunq/sdk_csharp#93) #105

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Added net standard 2 support. (bunq/sdk_csharp#93) #105

merged 2 commits into from
Jun 25, 2018

Conversation

nduijvelshoff
Copy link
Contributor

@nduijvelshoff nduijvelshoff commented Jun 22, 2018 •
edited by OGKevin

@OGKevin OGKevin added this to the 1.0.0 milestone Jun 22, 2018
@OGKevin OGKevin added this to To do in 1.0.0 - SDK via automation Jun 22, 2018
@OGKevin OGKevin moved this from To do to open PR in 1.0.0 - SDK Jun 22, 2018
@OGKevin
Copy link
Contributor

OGKevin commented Jun 22, 2018

@nduijvelshoff i just checked out your branch in Rider. Its throwing a lot of errors 😅

screen shot 2018-06-22 at 11 02 04

I'm not sure if my IDE settings are incorrect or that the SDK is broken 🤔. Do you happen to know if I'm missing a settings or not before i go on a google hunt.

@nduijvelshoff nduijvelshoff force-pushed the add-net-2-support-bunq/sdk_csharp#93 branch 3 times, most recently from a9fa113 to aa93d76 Compare June 22, 2018 09:47
@nduijvelshoff nduijvelshoff force-pushed the add-net-2-support-bunq/sdk_csharp#93 branch from aa93d76 to 60c90fd Compare June 22, 2018 09:54
@OGKevin
Copy link
Contributor

OGKevin commented Jun 25, 2018

Hmm im still getting

  Microsoft.NET.TargetFrameworkInference.targets(126, 5): [null] The current .NET SDK does not support targeting .NET Standard 2.0.  Either target .NET Standard 1.6 or lower, or use a version of the .NET SDK that supports .NET Standard 2.0.

@OGKevin
Copy link
Contributor

OGKevin commented Jun 25, 2018

Ok turns out my dotnet version was outdated 😂.

It builds now!

However tests are broken, but #87 and #90 will fix that. So i wont block your MR for failing tests as the solution build and they are broken on develop as-is.

Thanks for this MR.

@OGKevin OGKevin merged commit a7d3a60 into bunq:develop Jun 25, 2018
1.0.0 - SDK automation moved this from open PR to merged Jun 25, 2018
@OGKevin
Copy link
Contributor

OGKevin commented Jun 25, 2018

@andrederoos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OGKevin OGKevin OGKevin approved these changes

Assignees
No one assigned
Labels
Can be merged
Projects
No open projects
1.0.0 - SDK
  
merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.net standard 2.0 support
2 participants
@nduijvelshoff @OGKevin