Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response is missing response headers and pagination #33

Closed
dnl-blkv opened this issue Aug 9, 2017 · 0 comments
Closed

Response is missing response headers and pagination #33

dnl-blkv opened this issue Aug 9, 2017 · 0 comments
Assignees
Milestone

Comments

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 9, 2017

How to Reproduce

  1. Make a valid listing request to bunq API via the PHP SDK
  2. Make a valid get/put/post/delete request to bunq API via the PHP SDK

What Should Happen

  1. The response contains response headers and pagination
  2. The response contains response headers

What Happens

  1. The response does not contain response header nor pagination
  2. The response does not contain response header

Notes

  1. The structural fix would be to introduce BunqResponse object which, besides the response model, includes the response headers and pagination
@dnl-blkv dnl-blkv self-assigned this Aug 9, 2017
@OGKevin OGKevin added this to the v0.10.0 milestone Aug 9, 2017
dnl-blkv added a commit that referenced this issue Aug 9, 2017
dnl-blkv added a commit that referenced this issue Aug 9, 2017
dnl-blkv added a commit that referenced this issue Aug 9, 2017
andrederoos added a commit that referenced this issue Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants