#33 bunq response #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrederoos
requested changes
Aug 9, 2017
example/user_example.php
Outdated
| // Retrieve the active user. | ||
| /** @var User[] $users */ | ||
| $users = User::listing($apiContext)->getValue(); | ||
| $user= $users[INDEX_FIRST]->getUserCompany(); |
| */ | ||
| public function get($uri, array $customHeaders = []) | ||
| { | ||
| return $this->request(self::METHOD_GET, $uri, [], $customHeaders); |
There was a problem hiding this comment.
bundle the CRUD functions together?
| @@ -36,18 +36,20 @@ class AttachmentConversationContent extends BunqModel | |||
| * @param int $attachmentId | |||
| * @param string[] $customHeaders | |||
| * | |||
| * @return string|StreamInterface | |||
| * @return BunqResponse<string> | |||
There was a problem hiding this comment.
not really php type ;-)
There was a problem hiding this comment.
is this on purpose added to the generator?
There was a problem hiding this comment.
Yes, this one is on purpose. For now it is just an indicator of which type is enclosed as value. Further on I will capitalize the type name, get rid of < and >, and generate BunqResponse extensions featuring proper documentation.
| @@ -59,13 +60,13 @@ class AttachmentMonetaryAccount extends BunqModel | |||
| * @param int $monetaryAccountId | |||
| * @param string[] $customHeaders | |||
| * | |||
| * @return int | |||
| * @return BunqResponse<int> | |||
andrederoos
approved these changes
Aug 10, 2017
OGKevin
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33