Optimise test framework auto topup #120 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
force-pushed
the
optimise_test_framework_auto_topup_#120
branch
from
88b5149
to
36529a3
Compare
1 task
sandervdo
suggested changes
Apr 5, 2018
tests/BunqSdkTestBase.php
Outdated
| */ | ||
| const SPENDING_MONEY_AMOUNT = '500'; | ||
| const SPENDING_MONEY_RECIPIENT = 'sugardaddy@bunq.com'; | ||
| const SPENDING_MONEY_DESCRIPTION = 'sdk php test, thanks daddy <3 - OG'; |
There was a problem hiding this comment.
Why - OG? I'd suggest to keep it clean.
There was a problem hiding this comment.
Where's the fun in that? 😜
| new Amount(self::PAYMENT_AMOUNT_IN_EUR, self::PAYMENT_CURRENCY), | ||
| $this->getPointerUserBravo(), | ||
| self::PAYMENT_DESCRIPTION | ||
| ); | ||
|
|
||
| static::assertNotNull($response); | ||
| } | ||
|
|
||
| /** | ||
| * Test sending money to other monetaryAccount. | ||
| * | ||
| * This test has no assertion as of its testing to see if the code runs without errors. |
There was a problem hiding this comment.
This test has no assertion as it is testing whether the code runs without errors.
| @@ -82,12 +84,14 @@ public function testSendMoneyToOtherMonetaryAccount() | |||
| * | |||
| * @depends testSendMoneyToOtherMonetaryAccount | |||
| */ | |||
| public function testSendMessageToPayment() | |||
| public function testSendMessageToPayment(BunqResponseInt $paymentId) | |||
| { | |||
| $chatId = PaymentChat::create( | |||
There was a problem hiding this comment.
fits on one line? On purpose formatted like this?
OGKevin
force-pushed
the
optimise_test_framework_auto_topup_#120
branch
from
59b2aff
to
8f959d2
Compare
|
@sandervdo please 👀 |
sandervdo
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes/fixes the following issues: