Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user agent generation in ApiClient #31

Merged
merged 3 commits into from
Aug 7, 2017
Merged

Fix user agent generation in ApiClient #31

merged 3 commits into from
Aug 7, 2017

Conversation

dnl-blkv
Copy link
Contributor

@dnl-blkv dnl-blkv commented Aug 7, 2017

Fixes #30

@dnl-blkv dnl-blkv requested a review from qurben August 7, 2017 13:53
qurben
qurben approved these changes Aug 7, 2017
View reviewed changes
Copy link
Contributor

@qurben qurben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, very sorry.

@qurben qurben merged commit 08fbb7a into develop Aug 7, 2017
@qurben qurben deleted the 30-fix-user-agent branch August 7, 2017 13:58
@OGKevin OGKevin added this to the Patch 0.9.2 milestone Aug 7, 2017
@dnl-blkv
Copy link
Contributor Author

dnl-blkv commented Aug 7, 2017

@qurben it's Ok, it is a very small one :)

@dnl-blkv
Copy link
Contributor Author

dnl-blkv commented Aug 7, 2017

@andrederoos

@OGKevin OGKevin modified the milestones: Patch 0.9.2, v0.10.0 Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qurben qurben qurben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dnl-blkv @qurben @OGKevin