Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Agent header generation is broken in ApiClient #30

Closed
dnl-blkv opened this issue Aug 7, 2017 · 0 comments
Closed

User Agent header generation is broken in ApiClient #30

dnl-blkv opened this issue Aug 7, 2017 · 0 comments
Assignees
@dnl-blkv
Labels
bug

Comments

@dnl-blkv
Copy link
Contributor

dnl-blkv commented Aug 7, 2017

How to Reproduce

  1. Make an API request with the latest version of PHP SDK

What Should Happen

  1. Request goes smooth

What Happens

  1. Error

Notes

  1. The error happens because ApiClient tries to get the version from composer.json. However, the version is not present there anymore since #25 Update directory for composer scripts, also omit version. #26.
@dnl-blkv dnl-blkv added the bug label Aug 7, 2017
@dnl-blkv dnl-blkv changed the title User Agent generation is broken User Agent header generation is broken in ApiClient Aug 7, 2017
dnl-blkv added a commit that referenced this issue Aug 7, 2017
@dnl-blkv
#30 fix constant name
3f33f16
@dnl-blkv dnl-blkv mentioned this issue Aug 7, 2017
Merged
@OGKevin OGKevin added this to the Patch 0.9.1 milestone Aug 7, 2017
@qurben qurben closed this as completed in #31 Aug 7, 2017
@dnl-blkv dnl-blkv removed this from the Patch 0.9.2 milestone Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnl-blkv dnl-blkv

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnl-blkv @OGKevin