Add Pagination and missing fields/endpoints [#15] #43
Conversation
dnl-blkv
changed the title
|
@OGKevin Please check if it is good with PHP 5.6 and assign to @andrederoos once reviewed (don't merge yet!) Yeeah, that's a lot :D |
|
@OGKevin oh yep, that was 5.6! |
| */ | ||
| protected $pinCodeAssignment; | ||
|
|
||
| /** | ||
| * ID of the MA to be used as fallback for this card if insufficient |
There was a problem hiding this comment.
This is not generated right ? 😁 Please spell out monetary account
There was a problem hiding this comment.
@OGKevin What makes you think it is not generated? src/Model/Generated/Card.php :D
There was a problem hiding this comment.
Aaaahhhhh .gitattributes, will make PR tonight.
src/Http/Pagination.php
Outdated
| protected $count; | ||
|
|
||
| /** | ||
| * @param string[][] $paginationJson |
There was a problem hiding this comment.
This is not a nested array correct ?
| { | ||
| $this->pinCodeAssignment = $pinCodeAssignment; | ||
| } | ||
|
|
||
| /** | ||
| * ID of the MA to be used as fallback for this card if insufficient |
There was a problem hiding this comment.
src/Model/Generated/Card.php
| protected $pinCodeAssignment; | ||
|
|
||
| /** | ||
| * ID of the MA to be used as fallback for this card if insufficient |
There was a problem hiding this comment.
src/Model/Generated/CardDebit.php
| } | ||
|
|
||
| /** | ||
| * ID of the MA to be used as fallback for this card if insufficient |
There was a problem hiding this comment.
src/Model/Generated/CardDebit.php
|
@OGKevin Please take a look and assign to @andrederoos if it is OK :) |
|
Ok LGTM, @andrederoos please review, but do not merge yet. Need to run tests after your review 🥇 |
|
@dnl-blkv all tests passing on 7.1, please include tests for pagination as we discussed. |
|
@OGKevin this is now also ready for review; tests passing! Please take a look and then assign to @andrederoos |
src/Http/ApiClient.php
Outdated
| $headers = []; | ||
|
|
||
| foreach ($response->getHeaders() as $headerKey => $headerValues) { | ||
| $headers[$headerKey] = join(self::GLUE_HEADER_VALUE, $headerValues); |
There was a problem hiding this comment.
was not familiar with this alias, please use implode(). why php introduces aliases is a big mystery ;-)
| /** | ||
| * @return Pagination|null | ||
| */ | ||
| public function getPagination() |
There was a problem hiding this comment.
getPaginationOrNull? I think really helps making code breaks less... your call..
There was a problem hiding this comment.
It is the problem with the absence of proper notion of nullability in PHP. With PHP 7.1 we will have it, and IDE will be able to say "hey, it can be null!". I'd just leave it as is because then with PHP 7.1 this won't need to be changed back.
In Java, for instance, we do not need to say orNull because IDEs do it for us :)
Fixes #15