Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Python version to 3.5.3 #108

Closed
2 tasks done
eavanvalkenburg opened this issue Oct 17, 2018 · 9 comments · Fixed by #109
Closed
2 tasks done

Minimum Python version to 3.5.3 #108

eavanvalkenburg opened this issue Oct 17, 2018 · 9 comments · Fixed by #109

Comments

@eavanvalkenburg
Copy link
Contributor

Is it really using 3.6 specific functions? (change #85) I'm working on integrating this with Home Assistant (#home-assistant/core/pull/17478) , but it has a minimum python version of 3.5.3 and so it won't work right now. And quickly looking through the 3.6 changes, I don't see much things there that effect this sdk (for instance there are no f-strings used).

SDK version and environment

  • Tested on 1.1.0
  • Sandbox
  • Production
@eavanvalkenburg
Copy link
Contributor Author

It seemed to have been a fix based on this issue: #73 (comment) and that was fixed in Python 3.5.

@OGKevin
Copy link
Contributor

OGKevin commented Oct 17, 2018

The issue you reference is indeed the reason why the minimum python version got raised.

If you can decrease it to 3.5 and ensure that nothing explodes while running it on 3.5 then I don’t see a reason why to no decrease it 3.5 😊

@eavanvalkenburg
Copy link
Contributor Author

The issue you reference is indeed the reason why the minimum python version got raised.

If you can decrease it to 3.5 and ensure that nothing explodes while running it on 3.5 then I don’t see a reason why to no decrease it 3.5 😊

ok, great, I'll try to test that next week!

@OGKevin
Copy link
Contributor

OGKevin commented Oct 24, 2018

Thanks for your contribution @eavanvalkenburg :)

@eavanvalkenburg
Copy link
Contributor Author

Thanks @OGKevin, any idea when you guys will do a new release to pypi?

@kojoru
Copy link
Contributor

kojoru commented Oct 25, 2018

@eavanvalkenburg we'll iron out a few more things on our side first and then do a release. Shouldn't take longer than a few days.

@eavanvalkenburg
Copy link
Contributor Author

@kojoru any updates on this?

@eavanvalkenburg
Copy link
Contributor Author

guys? @kojoru @OGKevin

@OGKevin
Copy link
Contributor

OGKevin commented Mar 5, 2019

@eavanvalkenburg unfortunately i've been removed as maintainer so i cant help you here :( its up to @kojoru

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants