Edits to allow Python 3.5.3 as minimum #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGKevin
suggested changes
Oct 24, 2018
VERSION
Outdated
| 1.1.1 |
There was a problem hiding this comment.
Please revert this back. When a new version is released, we will do the version bump.
bunq/sdk/client.py
Outdated
| @@ -49,7 +49,7 @@ class ApiClient(object): | |||
| HEADER_RESPONSE_ID_LOWER_CASED = 'x-bunq-client-response-id' | |||
|
|
|||
| # Default header values | |||
| _USER_AGENT_BUNQ = 'bunq-sdk-python/1.1.0' | |||
| _USER_AGENT_BUNQ = 'bunq-sdk-python/1.1.1' | |||
setup.py
Outdated
| @@ -24,7 +24,7 @@ | |||
| # Versions should comply with PEP440. For a discussion on single-sourcing | |||
| # the version across setup.py and the project code, see | |||
| # https://packaging.python.org/en/latest/single_source_version.html | |||
| version='1.1.0', | |||
| version='1.1.1', | |||
kojoru
reviewed
Oct 24, 2018
setup.py
Outdated
| @@ -56,11 +56,12 @@ | |||
|
|
|||
| # Specify the Python versions you support here. In particular, ensure | |||
| # that you indicate whether you support Python 2, Python 3 or both. | |||
| 'Programming Language :: Python :: 3.5.3', | |||
| 'Programming Language :: Python :: 3.6', | |||
| ], | |||
|
|
|||
| # Require Python version equal or higher than Python 3.6. | |||
There was a problem hiding this comment.
Please fix the comment here
There was a problem hiding this comment.
Suggested change
| # Require Python version equal or higher than Python 3.6. | |
| # Require Python version equal or higher than specified version |
There was a problem hiding this comment.
Good catch, I also noticed that the classifiers do not have minor version (under 3.5) and those are only used for searching on pypi.org. The python_requires field is the setup time check.
kojoru
approved these changes
Oct 24, 2018
OGKevin
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just went through this, I created a virtualenv with Python 3.5.3. Just had to make some small adjustments in the tests, nothing in the source. Some of the tests used the new Python 3.6 syntax for strong typing, replaced that with Asserts on the types after create. And one test used a function from the Secrets package that is new in 3.6, replaced that with a direct function when running on Python < 3.6.
Otherwise, all tests work! So raised the version to 1.1.1 and updated the setup.py for the minimum version of Python.
This PR closes/fixes the following issues: