Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased min python version to 3.6. (bunq/sdk_python#73) #85

Merged
merged 5 commits into from
May 1, 2018

Conversation

OGKevin
Copy link
Contributor

@OGKevin OGKevin commented Apr 8, 2018

References #73

@OGKevin OGKevin added this to the 0.13.5 milestone Apr 8, 2018
@OGKevin OGKevin self-assigned this Apr 8, 2018
@OGKevin OGKevin force-pushed the increase_python_version_bunq/sdk_php#73 branch from 5938de8 to a78cc79 Compare April 8, 2018 06:51
@OGKevin OGKevin force-pushed the increase_python_version_bunq/sdk_php#73 branch from a78cc79 to 43fcbd7 Compare April 8, 2018 06:52
@OGKevin OGKevin changed the title Increased min python version to 3.6. (bunq/sdk_php#73) Increased min python version to 3.6. (bunq/sdk_python#73) Apr 8, 2018
Copy link

@JordyHeemskerk JordyHeemskerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change

setup.py Outdated
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
],

# Require Python version equal or more than Python 3.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your change, but should be equal or higher than and also adjust the version requirement in the comment.

@OGKevin OGKevin force-pushed the increase_python_version_bunq/sdk_php#73 branch from eb0c9e5 to 2bb0275 Compare April 12, 2018 15:25
@OGKevin
Copy link
Contributor Author

OGKevin commented Apr 12, 2018

@JordyHeemskerk pushed all yours again.

@OGKevin OGKevin merged commit a13f81b into develop May 1, 2018
@OGKevin OGKevin deleted the increase_python_version_bunq/sdk_php#73 branch May 1, 2018 11:46
@OGKevin
Copy link
Contributor Author

OGKevin commented May 1, 2018

@andrederoos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants