Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify scope handling #14

Closed
burberius opened this issue Jul 24, 2017 · 2 comments
Closed

Unify scope handling #14

burberius opened this issue Jul 24, 2017 · 2 comments
Assignees
@GoldenGnu

Comments

@burberius
Copy link
Owner

Currently the scopes are used in three ways: String[], Set, and just a String
That should be unified to only one, preferable Set so checking the supported ones as expected by #13 is easy.
@burberius burberius mentioned this issue Jul 24, 2017
Closed
@GoldenGnu
Copy link
Collaborator

GoldenGnu commented Aug 30, 2017 •
edited

Affected classes/methods are:
/auth/CharacterInfo.java -> getScopes()
/auth/OAuth.java -> getAuthorizationUri()
/auth/SsoScopes.java

@GoldenGnu GoldenGnu self-assigned this Dec 21, 2017
GoldenGnu added a commit to GoldenGnu/eve-esi that referenced this issue Dec 21, 2017
@GoldenGnu
Unified scope handling
b7c4eeb 
Always use Set for scopes (Issue burberius#14)
@GoldenGnu GoldenGnu mentioned this issue Dec 21, 2017
Merged
GoldenGnu added a commit that referenced this issue Dec 30, 2017
@GoldenGnu
Unified scope handling (#49)
7388947 
Always use Set for scopes (Issue #14)
@GoldenGnu
Copy link
Collaborator

Completed with PR #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GoldenGnu GoldenGnu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burberius @GoldenGnu