add value() and string() to adapter, update docs

burdiuz · Aug 23, 2018 · f814ca8 · f814ca8
1 parent 009342e
commit f814ca8
Show file tree

Hide file tree

Showing 10 changed files with 64 additions and 20 deletions.
diff --git a/dist/tree-walker.js b/dist/tree-walker.js
diff --git a/dist/tree-walker.js.map b/dist/tree-walker.js.map
diff --git a/dist/tree-walker.min.js b/dist/tree-walker.min.js
diff --git a/dist/tree-walker.min.js.map b/dist/tree-walker.min.js.map
diff --git a/example/onode-adapter.js b/example/onode-adapter.js
@@ -24,6 +24,8 @@
     getChildAt: (item, index = 0) => adapter.toNode(item).children[index],
     getNodeParent: (item) => adapter.toNode(item).parent,
     getNodeRoot: (item) => adapter.toNode(item).root,
+    valueOf: (item) => item.valueOf(),
+    toString: (item) => item.toString(),
   };
 
   target.ONodeAdapter = adapter;

diff --git a/example/tree-walker.min.js b/example/tree-walker.min.js
diff --git a/example/tree-walker.min.js.map b/example/tree-walker.min.js.map
diff --git a/source/augmentations/__tests__/core.js b/source/augmentations/__tests__/core.js
@@ -5,21 +5,50 @@ describe('Core augmentations', () => {
   let source;
   let root;
 
-  beforeEach(() => {
-    source = getSourceTree();
-    root = create(source, ONodeAdapter);
-  });
+  describe('When adapter has methods', () => {
+    beforeEach(() => {
+      source = getSourceTree();
+      root = create(source, {
+        ...ONodeAdapter,
+        string: () => 'ONode String',
+        value: () => 'ONode Value',
+      });
+    });
+
+    describe('toString()', () => {
+      it('should return unwrapped source node', () => {
+        expect(root.first.toString()).toBe('ONode String');
+      });
+    });
 
-  describe('toString()', () => {
-    it('should return unwrapped source node', () => {
-      expect(root.first.toString()).toBe('[ONode name="first" {"level":1}]');
+    describe('valueOf()', () => {
+      it('should return unwrapped source node', () => {
+        expect(root.first.valueOf()).toBe('ONode Value');
+      });
     });
   });
 
-  describe('valueOf()', () => {
-    it('should return unwrapped source node', () => {
-      expect(root.first.valueOf()[0]).toBeInstanceOf(ONode);
-      expect(root.first.valueOf()[0].name).toBe('first');
+  describe('When adapter does not have methods', () => {
+    beforeEach(() => {
+      source = getSourceTree();
+      root = create(source, {
+        ...ONodeAdapter,
+        string: undefined,
+        value: undefined,
+      });
+    });
+
+    describe('toString()', () => {
+      it('should return unwrapped source node', () => {
+        expect(root.first.toString()).toBe('[ONode name="first" {"level":1}]');
+      });
+    });
+
+    describe('valueOf()', () => {
+      it('should return unwrapped source node', () => {
+        expect(root.first.valueOf()[0]).toBeInstanceOf(ONode);
+        expect(root.first.valueOf()[0].name).toBe('first');
+      });
     });
   });
 });
diff --git a/source/augmentations/core.js b/source/augmentations/core.js
@@ -1,5 +1,6 @@
-const toString = (node) => node.toString();
-const valueOf = (node) => node;
+const toString = (node, adapter) =>
+  adapter.string ? adapter.string(node) : node.toString();
+const valueOf = (node, adapter) => (adapter.value ? adapter.value(node) : node);
 
 export default {
   toString,

diff --git a/stub-adapter.js b/stub-adapter.js
@@ -114,6 +114,18 @@ const adapter = {
    * @return {Node}
    */
   getNodeRoot: fn,
+  /**
+   * Get root node.
+   * @param {Node|Node[]} node
+   * @return {Object}
+   */
+  value: (item) => item,
+  /**
+   * Get root node.
+   * @param {Node|Node[]} node
+   * @return {String}
+   */
+  string: (item) => item.toString(),
 };
 
 export default adapter;