Playback slider, multiple anchors #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it with a breakpoint slider. Allows dragging the playback slider when paused at a breakpoint.
…one anchor can exist for each breakpoint hit.
burg
pushed a commit
that referenced
this pull request
Aug 30, 2012
Cherrypick Jake's improvements to playback slider, multiple anchors from Mercurial.
|
Let's see if Github was smart enough to see that I already added back the images. |
burg
referenced
this pull request
Sep 4, 2012
https://bugs.webkit.org/show_bug.cgi?id=93248 Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-08-07 Reviewed by Kentaro Hara. With the support of [TypedArray] we can remove the custom calls toV8(). TypedArray spec : http://www.khronos.org/registry/typedarray/specs/latest/#7 Tests: TestTypedArray.idl Tests under below folders should pass as this does not cause any behavioral changes. fast/canvas/webgl compositing/webgl * bindings/js/JSInt8ArrayCustom.cpp: * bindings/js/JSUint8ArrayCustom.cpp: * bindings/js/JSUint8ClampedArrayCustom.cpp: * bindings/scripts/CodeGeneratorV8.pm: (GenerateImplementation): Modified Generator code to generate bindings for toV8(). (IsWrapperType): (GetTypeNameOfExternalTypedArray): Method to get view type of TypedArray. * bindings/scripts/test/V8/V8Float64Array.cpp: Tests results. (WebCore::toV8): * bindings/v8/custom/V8Float32ArrayCustom.cpp: Removed custom call toV8(). * bindings/v8/custom/V8Float64ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Int16ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Int32ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Int8ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Uint16ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Uint32ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Uint8ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp: Ditto. * html/canvas/Int8Array.idl: Using TypedArray. * html/canvas/Uint8Array.idl: Ditto. * html/canvas/Uint8ClampedArray.idl: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
burg
pushed a commit
that referenced
this pull request
Feb 14, 2013
https://bugs.webkit.org/show_bug.cgi?id=78454 Unreviewed. Rebaseline #7 of N. * platform/chromium-linux/fast/replaced/width100percent-image-expected.png: * platform/chromium-mac-leopard/fast/replaced/width100percent-image-expected.png: * platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png: Added. * platform/chromium-mac-snowleopard/platform/chromium/compositing/img-layer-grow-expected.png: Added. * platform/chromium-mac/fast/replaced/width100percent-image-expected.png: Removed. * platform/chromium-win/fast/replaced/width100percent-image-expected.png: * platform/chromium-win/platform/chromium/compositing/img-layer-grow-expected.png: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
burg
referenced
this pull request
Feb 14, 2013
https://bugs.webkit.org/show_bug.cgi?id=93248 Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-08-07 Reviewed by Kentaro Hara. With the support of [TypedArray] we can remove the custom calls toV8(). TypedArray spec : http://www.khronos.org/registry/typedarray/specs/latest/#7 Tests: TestTypedArray.idl Tests under below folders should pass as this does not cause any behavioral changes. fast/canvas/webgl compositing/webgl * bindings/js/JSInt8ArrayCustom.cpp: * bindings/js/JSUint8ArrayCustom.cpp: * bindings/js/JSUint8ClampedArrayCustom.cpp: * bindings/scripts/CodeGeneratorV8.pm: (GenerateImplementation): Modified Generator code to generate bindings for toV8(). (IsWrapperType): (GetTypeNameOfExternalTypedArray): Method to get view type of TypedArray. * bindings/scripts/test/V8/V8Float64Array.cpp: Tests results. (WebCore::toV8): * bindings/v8/custom/V8Float32ArrayCustom.cpp: Removed custom call toV8(). * bindings/v8/custom/V8Float64ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Int16ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Int32ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Int8ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Uint16ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Uint32ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Uint8ArrayCustom.cpp: Ditto. * bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp: Ditto. * html/canvas/Int8Array.idl: Using TypedArray. * html/canvas/Uint8Array.idl: Ditto. * html/canvas/Uint8ClampedArray.idl: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
burg
referenced
this pull request
Feb 14, 2013
https://bugs.webkit.org/show_bug.cgi?id=40272 Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-08-20 Reviewed by Kenneth Rohde Christiansen. Source/WTF: According to the Uint8ClampedArray spec (http://www.khronos.org/registry/typedarray/specs/latest/#7.1) which references WebIDL's clamping rules, with implications defined in http://www.w3.org/TR/WebIDL/#es-octet we need to round to nearest integer, and to the even one if exactly halfway in between. As a solution: applying C99's lrint which, in default rounding mode, does that. The updated version of test 2d.imageData.object.round.html test passes now. * wtf/MathExtras.h: (lrint): Assembly based implementation for MSVC under X86, otherwise falling back to casting. * wtf/Uint8ClampedArray.h: (WTF::Uint8ClampedArray::set): lrint instead of simple rounding. LayoutTests: Fixing expectations for the imageData rounding test, unskipping the tests on all ports. * canvas/philip/tests/2d.imageData.object.round.html: Fixing expected results according to "round to even in halfway case". * fast/canvas/canvas-ImageData-behaviour-expected.txt: Fixing expected results according to "round to even in halfway case". * fast/canvas/canvas-ImageData-behaviour.js: Fixing expected results according to "round to even in halfway case". * platform/chromium/TestExpectations: Updating bug id for 2d.imageData.object.round.html and for wrap case, adding SVG case for rebaselining. * platform/efl/Skipped: 2d.imageData.object.round.html * platform/efl/TestExpectations: Moving 2d.imageData.object.wrap.html case here with new bug id. * platform/gtk/TestExpectations: Unskippng 2d.imageData.object.round.html, updating bug id for wrap case. * platform/mac/Skipped: Unskipping 2d.imageData.object.round.html. * platform/qt/Skipped: Unskipping 2d.imageData.object.round.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
burg
pushed a commit
that referenced
this pull request
Feb 14, 2013
https://bugs.webkit.org/show_bug.cgi?id=99899 Reviewed by Ryosuke Niwa. We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple performance tests and measure their memory footprint and performance that way. This change moves and renames the related files to their new location and adds html/js wrappers for them. This is the #7 (last) commit of the whole patch. * PageLoad: Removed. * PageLoad/svg: Removed. * PageLoad/svg/LICENSES: Removed. * PageLoad/svg/files: Removed. * PageLoad/svg/files/33041-Samurai.svg: Removed. * PageLoad/svg/files/42450-under the see.svg: Removed. * PageLoad/svg/files/world-iso.svg: Removed. * PageLoad/svg/svg.pltsuite: Removed. * SVG/Samurai.html: Added. * SVG/UnderTheSee.html: Added. * SVG/WorldIso.html: Added. * SVG/resources/LICENSES: Copied from PerformanceTests/PageLoad/svg/LICENSES. * SVG/resources/Samurai.svg: Copied from PerformanceTests/PageLoad/svg/files/33041-Samurai.svg. * SVG/resources/UnderTheSee.svg: Copied from PerformanceTests/PageLoad/svg/files/42450-under%20the%20see.svg. * SVG/resources/WorldIso.svg: Copied from PerformanceTests/PageLoad/svg/files/world-iso.svg. * SVG/resources/svg.pltsuite: Copied from PerformanceTests/PageLoad/svg/svg.pltsuite. * Skipped: Rename the files on the skipped list also. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
burg
pushed a commit
that referenced
this pull request
May 12, 2013
…, svg/filters, svg/stroke, svg/text, svg/wicd and svg/zoom directories after enabling subpixel layout for the GTK port. Patch #7 of approx. 24, `svn commit` is used directly to avoid the webkit-patch and ChangeLog overhead. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I applied patches for the week-old mercurial commits unifying the playback and breakpoint sliders and adding multiple anchors. I also added the missing image files for the frontend.