Add django-report-utils pieces; fix relation object field_name bug #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. updated imports and removed references to report-utils
…lds_from_model to copy the field object
|
Thanks. Typically I think makes sense to let the maintainers change the version number. I'd like to get full django 1.10 support before making a new 3.5 release. Getting there.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the fix for the field_name issue is in a method that was in django-report-utils, it seemed most straightforward to move the django-report-utils pieces into django-report-builder along with the fix.
I updated the version number; not sure if that's standard. Let me know if I should switch it back.
I assumed the existing tests are enough to catch any errors with moving the django-report-utils content.