Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation for Django 1.10 #257

Closed
wants to merge 4 commits into from
Closed

Conversation

brawaga
Copy link

@brawaga brawaga commented Jan 17, 2017

Without this patch I have no opportunity to build reports through many-to-many and reverse FKs.

Without this patch I have no opportunity to build reports through many-to-many and reverse FKs.
Forgot to import django.
Adaptation for Django 1.10.
@bufke
Copy link
Member

bufke commented Jan 17, 2017

Would you have time to contribute a unit test that passes in 1.9, fails in 1.10, but passes with this change? Unit tests are the best defense against regressions and keeping the code base maintainable with minimal time.

@brawaga
Copy link
Author

brawaga commented Jan 18, 2017

@bufke, I understand, but I am short in time now.
Moreover, I am getting familiar with django report builder for a little time and do not feel confident for now.
BTW, if I become ready for that, could you provide a way to run tests for django report builder, I did not get this from any page of https://django-report-builder.readthedocs.io/en/latest/.

Field choices render support for Django 1.10.
@bufke
Copy link
Member

bufke commented Jan 26, 2017

If I find any time I'll improve the docs on how unit tests should be written. The tests are just in one file here. You can run the demo app manually or by using docker - see the including docker-compose.yml file. Then just test with ./manage.py test as you would for any django project.

If someone can add unit tests here I'll merge it.

@bufke
Copy link
Member

bufke commented Aug 16, 2017

The utils issue was fixed. If there are other issues please open a new pull request with test. Changes that can break various django versions without a test proving which versions work will not be accepted.

@bufke bufke closed this Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants