Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing r to start up commands #658

Closed
wants to merge 1 commit into from
Closed

Conversation

nogates
Copy link

@nogates nogates commented May 7, 2018

Description

It looks like the default command to start zeus does not work anymore with ruby 2.5.1.

After digging around and reading some comments (1, 2), I've noticed that the versions below 2.5.1 were accepting -rubygems as a parameter, but this does not work anymore with version 2.5.1 and above

quico: ~ » ruby -v
ruby 2.3.1p112 (2016-04-26) [x86_64-linux-gnu]
quico: ~ »  ruby -rubygems  -e 'puts 1+1'
2
quico: ~ » rbenv shell 2.5.1            
quico: ~ » ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
quico: ~ » ruby -rubygems  -e 'puts 1+1'
Traceback (most recent call last):
        1: from /home/nogates/.rbenv/versions/2.5.1/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'
/home/nogates/.rbenv/versions/2.5.1/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require': cannot load such file -- ubygems (LoadError)

After adding that missing r, I can start zeus normally without having to do a zeus init and customizing the start command. Also, this works as well for versions prior 2.5.1

@nogates
Copy link
Author

nogates commented May 7, 2018

I guess this is related: rubygems/rubygems#2269

@simi
Copy link

simi commented May 10, 2018

I think this is actually related to ruby/ruby@e5e1f90.

@hsbt
Copy link

hsbt commented May 10, 2018

If zeus only supports Ruby 2.0+, It's better to remove -rrubygems from them.

@dcmorse
Copy link

dcmorse commented Nov 2, 2018

Please merge this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants