Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow delete multi rows #615

Merged
merged 2 commits into from Mar 27, 2020
Merged

Allow delete multi rows #615

merged 2 commits into from Mar 27, 2020

Conversation

deverlex
Copy link
Contributor

Hi, I want to provide function delete multi-rows on sheet

@manmartgarc
Copy link

This is a great addition - is this package no longer maintained by @burnash?

@paulte
Copy link

paulte commented Jan 3, 2020

Is there anything blocking a merge here @burnash, this would massively speed up a number of the use cases I've recently been looking at.

@burnash burnash added this to the 3.4.0 milestone Mar 27, 2020
@burnash
Copy link
Owner

burnash commented Mar 27, 2020

Thank you for your contribution and sorry for the late reply.

@burnash burnash merged commit 4f51f72 into burnash:master Mar 27, 2020
@burnash
Copy link
Owner

burnash commented Mar 27, 2020

@paulte nothing specific, when the PR arrived, unfortunately, I didn't have too much time to dig into it. Generally, it speeds things up when the description of the PR gives a background on why this addition is necessary and the PR has tests.
I've outlined this in the contributing guide but I understand that it's not always possible for contributors to follow the guide due to time constraints. Hence the delay. Sorry about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants